-
-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Support plugins defined as inner classes #1318
Support plugins defined as inner classes #1318
Conversation
91e7052
to
f148568
Compare
Hm, I may need some insights on what have failed since:
is there for me on unmodified |
Thank you @alexey-pelykh for this PR. These are possibly broken due to updated lint toolkit (in this case flake8 I suppose). At times upstream changes starts to show up as new lint errors in our repo :(. I'll address this in a separate PR and re-run/review this PR sometime morrow. Thanks again. |
@alexey-pelykh I am fixing the lint issues via #1321 , we should be able to get going on this PR thereafter. Meanwhile, could you add a few lines about capabilities that this PR adds to the |
@alexey-pelykh All looks good. Thank you again for your PR and included tests 🙏. Merging, we can update doc in a separate PR effort. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Support referencing the following plugin class by name and by type: