-
-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Support --hostnames #1325
Support --hostnames #1325
Conversation
1a4613b
to
f5e3add
Compare
461a979
to
8341ea0
Compare
8341ea0
to
cb7921f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. PTAL at my comment related to windows & its workflow.
Thank you
bc78ffc
to
0942dba
Compare
4d58af2
to
467cb2e
Compare
@abhinavsingh your turn to tame your CI :) |
I restarted the failed jobs. Due to certain integration tests, which uses upstream httpbin.org and pythonhosted.org, we end up receiving server side / rate limiting errors. As a result, these tests can fail sometimes. Usually, restarting them always makes them work. |
@alexey-pelykh So workflow went fine after restarting failed jobs. Docker and GHCR are related to secrets and permissions for PRs I suppose. I'll take another stab at it sometime tonight or morrow and merge it. Thank you for adding this capability. It certainly can be used to scale proxy.py even further on a single host machine. |
@abhinavsingh how's it going on your end? any changes needed? |
Hi @alexey-pelykh , apologies, I got derailed a release work past/this week. Promise, I'll take a look again and merge this weekend. Thank you. |
@alexey-pelykh LGTM, made few minor edits directly in the PR. Workflow revealed failures which led me to home-assistant/core#91283 🤦♂️ Damn. Will need to fix the |
No description provided.