vm: support additional disks #893
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ssakuh
force-pushed
the
feat/additional-disks
branch
from
e09ad4b to
7597068
Compare
ssakuh
force-pushed
the
feat/additional-disks
branch
from
7597068 to
fb84658
Compare
|
@abiosoft I have improved the implementation. please have a look |
|
Hi, thanks for your efforts so far. Can you kindly limit this PR to only support additional disks? Other fixes can happen in a separate PR. |
|
I would love to see support for additional disks merged. Besides separating all the cosmetic fixes in this PR, does this need some more work? |
|
This PR is would need to be closed, unfortunately. It is too behind (evident from the conflicts) and contains irrelevant changes. The ground work has actually been done to support additional disks eac8ef6. I am not sure how soon I will get to it but I have it planned. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds support for a new parameter in colima.yaml that will create and mount additional disks via limactl