Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Test: add comprehensive unit tests covering all ERC1155 functionalities #117

Merged
merged 15 commits into from
Mar 6, 2025
Merged

Test: add comprehensive unit tests covering all ERC1155 functionalities #117

merged 15 commits into from
Mar 6, 2025

Conversation

roleengineer
Copy link
Contributor

No description provided.

@roleengineer
(test-1155): implemented mock erc1155
76d6502
@roleengineer
(test-erc1155): added mock 1155 receivers
7db8c79
@roleengineer
(test-erc1155): initial test file, includes _acceptanceCheck and _upd…
19f927a 
…ate tests
@roleengineer
(test-erc1155): implemented test coverage over internal _mint function
3816d57
@roleengineer
(test-erc1155): test coverage over internal _burn function
99bde87
@roleengineer
(test-erc1155): test coverage over internal _updateWithAcceptanceChec…
5658aa0 
…k function
@roleengineer
(test-erc1155): test coverage over external safeTransferFrom function
19eddd3
@roleengineer
(test-erc1155): test coverage over external safeBatchTransferFrom fun…
eab3276 
…ction
@roleengineer
(test-erc1155): test coverage over view balanceOf function
27bfe99
@roleengineer
(test-erc1155): test coverage over view balanceOfBatch function
ef9fe80
@roleengineer
(test-erc1155): test coverage over external setApprovalForAll and vie…
e30a3b5 
…w isApprovedForAll functions
@roleengineer
(test-erc1155): test coverage around internal _setUri and view uri fu…
5b9bd78 
…nctions
@roleengineer
(test-erc1155): test coverage around view supportsInterface function
398ec33
@roleengineer
(test-erc1155): assert erc1155 receiver mocks supports interface
93757c8
@roleengineer
(test-erc1155): explicitly execute branches in order of 100% coverage
db952bb
benjaminbollen
benjaminbollen approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@benjaminbollen benjaminbollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for great work. I left one open question wrt the re-entrancy test, but I'm happy either way. Good for me to merge

@benjaminbollen benjaminbollen merged commit 8974c7e into beta Mar 6, 2025
1 check passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@benjaminbollen benjaminbollen benjaminbollen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roleengineer @benjaminbollen