Fix package scan only performance #3423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit disables license detection on files happening when the license CLI option is disabled for a package scan. Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
| @@ -219,79 +219,7 @@ | |||
| "holder": "Jiri Pirko\nAndrew Ayer", | |||
| "declared_license_expression": "lgpl-2.1-plus AND lgpl-2.1", | |||
| "declared_license_expression_spdx": "LGPL-2.1-or-later AND LGPL-2.1-only", | |||
| "license_detections": [ | |||
There was a problem hiding this comment.
Tracking this seperately at: #3424
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
AyanSinhaMahapatra
force-pushed
the
fix-package-scan-only-performance
branch
from
55aac5d
to
9d42d1e
Compare
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
|
Build scripts passed: https://github.com/AyanSinhaMahapatra/scancode-toolkit/actions/runs/5203365274 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a performance issue issue arising out of license detection on files happening in a single-threaded process_codebase step when the
license CLI option is disabled for a package scan.
Tasks
Run tests locally to check for errors.