Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

support parsing BUNDLED WITH #3444

Merged
merged 1 commit into from
Jun 30, 2023
Merged

support parsing BUNDLED WITH #3444

merged 1 commit into from
Jun 30, 2023

Conversation

akostadinov
Copy link
Contributor

@akostadinov akostadinov commented Jun 30, 2023 •
edited by AyanSinhaMahapatra
Loading

Gemfile.lock contains information about the version of Bundler used to generate it. Presently this information is not parse-able no matter if Bundler is only used to generate the file or is also a dependency of the project.

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Looked for possible updates in documentation and added updates if applicable
  • Updated CHANGELOG.rst

@akostadinov akostadinov changed the title <!-- Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks! * [x] - Checked Box * [ ] - Unchecked Box --> support parsing BUNDLED WITH Jun 30, 2023
@akostadinov
support parsing BUNDLED WITH
6edab47 
Signed-off-by: Aleksandar N. Kostadinov <akostadi@redhat.com>
@akostadinov akostadinov mentioned this pull request Jun 30, 2023
Closed
@pombredanne
Copy link
Member

Thank you ++ for this! ❤️

pombredanne
pombredanne approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you: this is neat, clean and tested. You rock.

@pombredanne pombredanne merged commit a15174f into aboutcode-org:develop Jun 30, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akostadinov @pombredanne