Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add new license detection rules #3575

Merged
merged 7 commits into from
Nov 9, 2023
Merged

Add new license detection rules #3575

merged 7 commits into from
Nov 9, 2023

Conversation

pombredanne
Copy link
Member

@pombredanne pombredanne commented Nov 9, 2023 •
edited by AyanSinhaMahapatra
Loading

These are misc. rules to improve detection, mostly for Maven edge cases.

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Looked for possible updates in documentation and added updates if applicable
  • Updated CHANGELOG.rst

@pombredanne
Add trailing LF to license rule texts
de920b9 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Add new license rules
7cb1d75 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
AyanSinhaMahapatra and others added 5 commits November 9, 2023 17:32
@AyanSinhaMahapatra
Fix failing test
3ac6fb5 
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@pombredanne
Add new license detection rules
3ecd6be 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Merge remote-tracking branch 'upstream/more-licenses' into more-licenses
67e2837
@pombredanne
Update license expectations to match new rules
005b7bf 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@AyanSinhaMahapatra
Add more license detection rules
8c70ccf 
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
AyanSinhaMahapatra
AyanSinhaMahapatra approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Merging this.

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 1c4d6be into develop Nov 9, 2023
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the more-licenses branch November 9, 2023 14:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@AyanSinhaMahapatra AyanSinhaMahapatra AyanSinhaMahapatra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pombredanne @AyanSinhaMahapatra