Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

TestRule.test_dump_rule_file: sort the rule file lists. #3582

Merged
merged 1 commit into from
Nov 15, 2023
Merged

TestRule.test_dump_rule_file: sort the rule file lists. #3582

merged 1 commit into from
Nov 15, 2023

Conversation

licquia
Copy link
Contributor

@licquia licquia commented Nov 13, 2023 •
edited by AyanSinhaMahapatra
Loading

Fixes #3581.

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Looked for possible updates in documentation and added updates if applicable
  • Updated CHANGELOG.rst

TestRule.test_dump_rule_file: sort the rule file lists.
7e35437 
Fixes aboutcode-org#3581.

Signed-off-by: Jeff Licquia <jeff@licquia.org>
pombredanne
pombredanne approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you ++

@AyanSinhaMahapatra
Copy link
Member

Thanks ++ @licquia , merging!

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 7b838ab into aboutcode-org:develop Nov 15, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_dump_rule_file depends on OS filename sorting
3 participants
@licquia @AyanSinhaMahapatra @pombredanne