Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add Misc updates #3662

Merged
merged 6 commits into from
Mar 15, 2024
Merged

Add Misc updates #3662

merged 6 commits into from
Mar 15, 2024

Conversation

pombredanne
Copy link
Member

@pombredanne pombredanne commented Feb 21, 2024 •
edited by AyanSinhaMahapatra
Loading

This PR contains miscellaneous small changes and fixes in tests, regex syntax and similar.
Thee are too small to be considered alone.

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

@pombredanne
Add new generated code clues
ec8fa50 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Use correct assert call
58ef3a9 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Use assert command for tests
3438cdd 
Also use proper name for var: test_envt confuse test discovery

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Use correct regex syntax
63c681b 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Make tests pass after cleanup
c8409f6 
Some tests never ran and the underlying needed some minor updates.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Drop section sign § from copyrights #3567
6df90d5 
Reference: #3667
Reported-by: Stefan @stefan6419846
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne
pombredanne commented Feb 27, 2024
View reviewed changes
Copy link
Member Author

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All green. @AyanSinhaMahapatra yours to review and merge

AyanSinhaMahapatra
AyanSinhaMahapatra approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pombredanne
Merging this!

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit ea8953b into develop Mar 15, 2024
34 checks passed
@pombredanne pombredanne deleted the misc-updates branch May 9, 2024 07:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@AyanSinhaMahapatra AyanSinhaMahapatra AyanSinhaMahapatra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pombredanne @AyanSinhaMahapatra