Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix pnpm workspace parsing and udpate package detection #4079

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Fix pnpm workspace parsing and udpate package detection #4079

merged 2 commits into from
Jan 9, 2025

Conversation

AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Jan 8, 2025 •
edited
Loading

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

@AyanSinhaMahapatra
Fix npm workspace parsing bug
cb7dbfe 
Reference: aboutcode-org/scancode.io#1521
Reported-by: @JonoYang
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Add support for pnpm-lock.yaml v9
f966c8f 
See https://github.com/pnpm/spec/blob/master/lockfile/9.0.md

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra AyanSinhaMahapatra changed the title Fix pnpm workspace parsing and package detection Fix pnpm workspace parsing and udpate package detection Jan 8, 2025
JonoYang
JonoYang approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@JonoYang JonoYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AyanSinhaMahapatra LGTM! Thanks for the fix!

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 54ee82e into develop Jan 9, 2025
40 checks passed
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the fix-npm-workspace-parsing branch January 9, 2025 10:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@JonoYang JonoYang JonoYang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when running scan_codebase on npm package using a download url source
2 participants
@AyanSinhaMahapatra @JonoYang