Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove the run_extractcode pipe in favor of extractcode API #312

Closed
tdruez opened this issue Aug 31, 2021 · 0 comments
Closed

Remove the run_extractcode pipe in favor of extractcode API #312

tdruez opened this issue Aug 31, 2021 · 0 comments
Assignees
@tdruez
Labels
enhancement New feature or request medium priority
Milestone
2021-08

Comments

@tdruez
Copy link
Contributor

tdruez commented Aug 31, 2021

Only the scan_codebase pipeline is using the run_extractcode pipe while every others pipelines are directly calling the extractcode function.

The run_extractcode pipe is based on a subprocess call and there's no reasons to maintain both approaches.
@tdruez tdruez added enhancement New feature or request medium priority labels Aug 31, 2021
@tdruez tdruez added this to the 2021-08 milestone Aug 31, 2021
@tdruez tdruez self-assigned this Aug 31, 2021
tdruez added a commit that referenced this issue Aug 31, 2021
@tdruez
Remove the run_extractcode pipe in favor of extractcode API #312
b24dcaf 
Signed-off-by: Thomas Druez <tdruez@nexb.com>
tdruez added a commit that referenced this issue Sep 2, 2021
@tdruez
Remove the run_extractcode pipe in favor of extractcode API #312 (#313)
b035f00 
Signed-off-by: Thomas Druez <tdruez@nexb.com>
@tdruez tdruez closed this as completed Sep 2, 2021
tdruez added a commit that referenced this issue Sep 3, 2021
@tdruez
Refactored the extract pipes into clean API #312
e52c4da 
- 2 pipes: extract_archive (extract to) and extract_archives (in place)
- Added tests

Signed-off-by: Thomas Druez <tdruez@nexb.com>
tdruez added a commit that referenced this issue Sep 3, 2021
@tdruez
Make unit test compatible with CI #312
1d7f801 
Signed-off-by: Thomas Druez <tdruez@nexb.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@tdruez tdruez

Labels
enhancement New feature or request medium priority
Projects
None yet
Milestone
2021-08
Development

No branches or pull requests
1 participant
@tdruez