Add support for using merge sort on generic objects implementing the … #7
Conversation
|
Hey, @Wyvernix thanks for checking out the project and being interested in contribute it it, I looked over it and it seems right, I would like to include generics for most of the algorithms. Before merging the pull request, a few tests will be required, testing |
|
@Wyvernix I saw you added more methods for other data types, what about generics? What do you think: is it necessary to add more methods covering those data types, or rather just one generic method that will cover all of them? I am not sure yet what's gonna be better for other to use this library, with a generic method or using more methods as you did. Please share your thoughts. |
…e Comparable interface. Added merge sort implementations for missing primitive types: byte, char, float, short, and long. Added test cases for each type.
Wyvernix
force-pushed
the
merge-sort-generic
branch
from
c871954 to
f4addcd
Compare
|
The issue with just adding the generic method to the class as I did is it does not support primitive arrays. It is not possible to call the generic method using an array of integers, for example. In order to support both Object arrays and primitive arrays in Java, both methods are required. An example in the official Java source code can be seen here : DualPivotQuicksort.java |
…Comparable interface.
The method was implemented using the existing methods as template. This is in reference to issue #3.