-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Configuration cleanup #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also regenerated documentation since some stuff has changed
jvanstraten
force-pushed
the
configuration-cleanup
branch
from
August 23, 2019 15:00
3a23be0
to
6bbbcf6
Compare
jvanstraten
force-pushed
the
configuration-cleanup
branch
from
August 23, 2019 15:02
6bbbcf6
to
e823a05
Compare
Codecov Report
@@ Coverage Diff @@
## master #1 +/- ##
==========================================
- Coverage 87.18% 82.72% -4.46%
==========================================
Files 26 69 +43
Lines 3206 4713 +1507
==========================================
+ Hits 2795 3899 +1104
- Misses 411 814 +403
Continue to review full report at Codecov.
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new code is pretty close to what it used to be in terms of functionality, only AXI fields are still missing. It's probably about time to merge it back into master.