Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Render null default values in SDL #1032

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Render null default values in SDL #1032

merged 1 commit into from
Jan 20, 2021

Conversation

maartenvanvliet
Copy link
Contributor

Literal null default values in arguments in the SDL notation triggered errors.

  • A pattern match was missing for the Language.NullValue when converting to Blueprint.Schema.InputValueDefinition
  • In the SDL rendered the Blueprint.Input.Null was not matched when in render_value

@binaryseed
Copy link
Contributor

Thanks!

@binaryseed binaryseed merged commit ffb5e12 into absinthe-graphql:master Jan 20, 2021
@maartenvanvliet maartenvanvliet mentioned this pull request Jan 24, 2022
Closed
@maartenvanvliet maartenvanvliet mentioned this pull request Aug 26, 2022
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maartenvanvliet @binaryseed