Fix default enum value present for SDL schemas #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TypeReference.unwrap/1 was passed in %TypeReference.Name{} struct in the
case of SDL schema's, and returns it. This fails in the subsequent lookup
in `enums`. We need to use TypeReference.to_type/2 to get
the actual atom type identifier for the `enums` lookup.
For macro schema's this is not an issue as the atom type identifier is
passed into TypeReference.unwrap/1.
kdawgwilk
approved these changes
Aug 29, 2022
benwilson512
approved these changes
Sep 6, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeReference.unwrap/1 was passed in %TypeReference.Name{} struct in the
case of SDL schema's, and returns it. This fails in the subsequent lookup
in
enums. We need to use TypeReference.to_type/2 to getthe actual atom type identifier for the
enumslookup.For macro schema's this is not an issue as the atom type identifier is
passed into TypeReference.unwrap/1.