Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Validate input object not being an Enum #1231

Merged

Conversation

rewritten
Copy link
Contributor

We have found out that in a query like this, when the complexArg argument is an input object:

{ someField(complexArg: SEEMS_AN_ENUM) }

the argument is discarded instead of being marked as an error like if it was a scalar.

This PR adds a parse check for Input.Enum for this case, and tests for this and other cases.

@benwilson512
Copy link
Contributor

Oops, great catch!

@rewritten
Copy link
Contributor Author

Thanks to @ssaenz and @JamieMaclean for spotting the issue.

@benwilson512 benwilson512 merged commit f47cc7f into absinthe-graphql:master Feb 17, 2023
@rewritten rewritten deleted the validate-input-object branch February 17, 2023 15:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants