Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

NOISSUE - Fix Websocket Adapter #2700

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

rodneyosodo
Copy link
Member

@rodneyosodo rodneyosodo commented Feb 11, 2025

What type of PR is this?

What does this do?

Which issue(s) does this PR fix/relate to?

  • Related Issue #
  • Resolves #

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

To be merged after #2695

@rodneyosodo rodneyosodo requested a review from a team as a code owner February 11, 2025 12:05
@rodneyosodo rodneyosodo changed the title WS NOISSUE - Fix Websocket Adapter Feb 11, 2025
@rodneyosodo rodneyosodo marked this pull request as draft February 11, 2025 12:08
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 40.90909% with 156 lines in your changes missing coverage. Please review.

Project coverage is 38.57%. Comparing base (da6e3e1) to head (014a9be).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/messaging/mqtt/pubsub.go 71.83% 27 Missing and 13 partials ⚠️
mqtt/forwarder.go 0.00% 31 Missing ⚠️
mqtt/tracing/forwarder.go 0.00% 31 Missing ⚠️
ws/handler.go 0.00% 31 Missing ⚠️
pkg/messaging/mqtt/publisher.go 23.07% 18 Missing and 2 partials ⚠️
ws/adapter.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2700      +/-   ##
==========================================
- Coverage   42.08%   38.57%   -3.52%     
==========================================
  Files         341       58     -283     
  Lines       47488     2849   -44639     
==========================================
- Hits        19987     1099   -18888     
+ Misses      25318     1664   -23654     
+ Partials     2183       86    -2097     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rodneyosodo rodneyosodo force-pushed the fix-websocket branch 2 times, most recently from 55c53cb to ddc40fd Compare February 14, 2025 09:01
This reverts commit cff6e7f.

Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
This reverts commit 87db3e6.

Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Use rabbitMQ alpine rather than management-alpine since we are enabling
that feature using config files

Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
This reverts commit 9d8918b.

Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
This reverts commit cff6e7f.

Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant