Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Tidy up idiokit.dns._dns exceptions #28

Merged
merged 2 commits into from
Jul 25, 2016
Merged

Tidy up idiokit.dns._dns exceptions #28

merged 2 commits into from
Jul 25, 2016

Conversation

jviide
Copy link
Contributor

@jviide jviide commented Jul 6, 2016

This pull request does some minor cleanups on how idiokit.dns._dns raises exceptions:

  • The unpack classmethod for A, AAAA and TXT types should raise NotEnoughData exceptions like other similar methods when there is not enough data.
  • Instead of checking the string lengths during TXT#pack the lengths should be checked when TXT is instantiated do better pinpoint the actual source of erroneous data.

Relevant tests are included.

@oherrala oherrala self-assigned this Jul 25, 2016
@oherrala oherrala merged commit 4c795e0 into abusesa:master Jul 25, 2016
@jviide jviide deleted the fix-dns-exceptions branch July 25, 2016 13:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants