Skip to content
This repository has been archived by the owner on Feb 7, 2025. It is now read-only.

Addition of Heading 4, Heading 5, and Heading 6 and updation of existing headings #293

Closed
d-e-v-esh opened this issue Mar 11, 2021 · 7 comments · Fixed by #302
Closed

Addition of Heading 4, Heading 5, and Heading 6 and updation of existing headings #293

d-e-v-esh opened this issue Mar 11, 2021 · 7 comments · Fixed by #302

Comments

@d-e-v-esh
Copy link
Contributor

Feature Request 🛍️

Updating the Existing Heading Size and addition of Heading 4, Heading 5 and, Heading 6 into the dropdown menu.

Use Case

Heading 1 = 25px => Stays the same
Heading 2 = 25px => Left-aligned to differentiate from H1
Heading 3 = 20px
Heading 4 = 18px
Heading 5 = 16px
Heading 6 = 14px => Same size as a normal paragraph, All capital letters, The same text formatting as the text used in Page Break:

110824137-c516a900-8260-11eb-9ba8-a5a0457bcc8b

@d-e-v-esh
Copy link
Contributor Author

@Michael-Grover Hey, I created the Headings issue. 👍

@d-e-v-esh
Copy link
Contributor Author

@Michael-Grover Something seems wrong with Heading 6. You can see it in the main demo. It looks something like this:

chrome_guwTC9C155

You can see the distance between H6 and Fin is much larger. Extra margin is being applied somewhere that I can't find.
And the margin gets significantly larger as the font size grows.
After implementing the above, Heading 5 looks totally normal like this:

chrome_qmlSTrFRFM

and Heading 6 looks like this:

chrome_rj7eIloc88

and if I increase the font size then it looks like this:

chrome_sjuByWZC1J

This is happening only with Heading 6. Do you have any idea what could be causing the problem?

@Michael-Grover
Copy link

@d-e-v-esh sorry, I'm not sure. Someone who is more familiar with CSS like @irmerk or @DianaLease may know

@d-e-v-esh
Copy link
Contributor Author

@Michael-Grover This problem was occurring because of the user agent stylesheet. Overriding the default styles by adding margin properties fixes the problem.

d-e-v-esh added a commit to d-e-v-esh/web-components that referenced this issue Mar 14, 2021
Signed-off-by: d-e-v-esh <59534570+d-e-v-esh@users.noreply.github.com>
@akk312000
Copy link

I would like to contribute and fix the issue.
Can you guide me how should I go forward into solving this issue.

@jolanglinais
Copy link
Member

@akk312000 @d-e-v-esh is working on this already as you can see in the Issue.

@d-e-v-esh I still haven't had time to look into this to give you feedback, sorry. I'm hoping to very soon.

@d-e-v-esh
Copy link
Contributor Author

@irmerk That is totally fine 👍

jolanglinais pushed a commit that referenced this issue Apr 2, 2021
Signed-off-by: d-e-v-esh <59534570+d-e-v-esh@users.noreply.github.com>
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants