Skip to content
This repository has been archived by the owner on Feb 7, 2025. It is now read-only.

fix(ui-markdown-editor):multi-para to list proper indent - I158 #252

Conversation

K-Kumar-01
Copy link
Contributor

Signed-off-by: k-kumar-01 kushalkumargupta4@gmail.com

Closes #158

Choosing multiple paragraphs and then converting them to list will now show points-bullet or numbers along with the indentation

Changes

  • Need to change the anchor and focus when selecting from bottom

Screenshots or Video

Selecting from bottom
Screenshot from 2021-02-20 23-49-03
Result
Screenshot from 2021-02-20 23-49-10

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname
  • Manual accessibility test performed
    • Keyboard-only access, including forms
    • Contrast at least WCAG Level A
    • Appropriate labels, alt text, and instructions

Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com>
@Michael-Grover
Copy link

@K-Kumar-01 , it looks like there are some unsuccessful checks. If you need help, I recommend asking @irmerk or @dselman

@K-Kumar-01
Copy link
Contributor Author

@K-Kumar-01 , it looks like there are some unsuccessful checks. If you need help, I recommend asking @irmerk or @dselman
@Michael-Grover
I am unable to understand the failure of the checks.
@irmerk @dselman
Could you please tell me what is the error?

@jolanglinais
Copy link
Member

The error logs look strange to me... @K-Kumar-01 I'd suggest force pushing the same code up to force Netlify to rebuild and we can see what the issue is.

Added comment for explanation

Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com>
@K-Kumar-01
Copy link
Contributor Author

The error logs look strange to me... @K-Kumar-01 I'd suggest force pushing the same code up to force Netlify to rebuild and we can see what the issue is.

@irmerk
I have added a commit(comment added) as I was not confident about force push.
@Michael-Grover
The PR build is successful now. Let me know if there are any changes required.

Copy link
Contributor

@dselman dselman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dselman dselman merged commit 1da7634 into accordproject:master Feb 23, 2021
@K-Kumar-01 K-Kumar-01 deleted the k-kumar-01/i158/list-paragraph-indentation branch February 23, 2021 18:57
@mttrbrts mttrbrts added the Type: Bug 🐛 Something isn't working label Mar 10, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Type: Bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing a group of paragraphs to a numbered list only indents the paragraphs
5 participants