This repository has been archived by the owner on Feb 7, 2025. It is now read-only.
fix(ui-markdown-editor): handle cut image operation - #294 #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cronus1007
changed the title
mttrbrts
reviewed
Mar 12, 2021
| @@ -130,10 +129,15 @@ export const MarkdownEditor = (props) => { | |||
| const CICERO_MARK_DOM = slateTransformer.toCiceroMark(SLATE_DOM); | |||
| const HTML_DOM = htmlTransformer.toHtml(CICERO_MARK_DOM); | |||
| const MARKDOWN_TEXT = ciceroMarkTransformer.toMarkdown(CICERO_MARK_DOM); | |||
| const [imageNode] = Editor.nodes(editor, { match: n => n.type === 'image' }); | |||
There was a problem hiding this comment.
@irmerk @DianaLease @dselman Is this the best way to detect if the operation applies to an 'image'?
There was a problem hiding this comment.
@irmerk @DianaLease @dselman Also tell me the best way to detect textnode.
There was a problem hiding this comment.
We have precedent here for detecting an image, see L175 under handleDrop in this file.
I'd look for other inspiration on a text node.
mttrbrts
reviewed
Mar 12, 2021
There was a problem hiding this comment.
Good spot @Cronus1007. I'm happy with the change, but will need a review from one of the maintainers with deeper knowledge of Slate to confirm.
jolanglinais
changed the title
jolanglinais
suggested changes
Mar 15, 2021
There was a problem hiding this comment.
This looks good to me. Can you rebase to get rid of 1c6ee38?
Signed-off-by: Cronus1007 <lit2019058@iiitl.ac.in>
jolanglinais
approved these changes
Mar 15, 2021
Cronus1007
added a commit
to Cronus1007/web-components
that referenced
this pull request
Mar 15, 2021
fix(ui-markdown-editor): handle cut image operation - accordproject#294 (accordproject#298)
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #294
The Cut operation that can't be performed upon the images is regulated.
Steps to see the Change
Screenshots or Video
Related Issues
Author Checklist
--signoffoption of git commit.masterfromfork:branchname