feat: support weight decimals #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the `shopspring/decimal` library to add support for decimal weight values. - Change each `Weight` field's type to `decimal.Decimal` - Replace `strconv.Atio()` with `decimal.NewFromString()` for Weight - Modify SQL statements to insert the decimal value - Update weight inputs to allow decimal places and a min value of zero This approach works without modifying the column type due to SQLite's type affinity. Ideally the column type would be changed to a more suitable type to better support other DBs, like PostgreSQL, in the future. However, that would require decisions to be made around migration processes, which may be better deferred until that work is undertaken. Resolves aceberg#4
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
shopspring/decimallibrary to add support for decimal weight values.Weightfield's type todecimal.Decimalstrconv.Atio()withdecimal.NewFromString()for WeightThis approach works without modifying the column type due to SQLite's type affinity. Ideally the column type would be changed to a more suitable type to better support other DBs, like PostgreSQL, in the future. However, that would require decisions to be made around migration processes, which may be better deferred until that work is undertaken.
Resolves #4