Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[python] EEG-BIDS Events replace Annotations; plus adding HED Support #1041

Merged

Conversation

jeffersoncasimir
Copy link
Contributor

@jeffersoncasimir jeffersoncasimir commented Jan 31, 2024

This PR has multiple Loris counterparts:

Events to Annotations: #9032
HED support: #9033

It aims to make the Python pipeline more compliant with the current BIDS standard.

It does so by replacing references of annotations files and terms with references to events files and terms.

It also brings in support for ingesting dataset-level (from dataset-level events.json) and instance-level (HED column in events.tsv) HED Tags.

Current HED limitations:

  • Limited support for instance-level events.json
  • No support for "value tags"
  • No support for "expanded definitions"
  • See Loris PRs for Loris-side limitations

It also does some file name refactoring in thedatabase_lib folder to standardize the name structure.
Some logic was also moved to new database_lib files.

MAKE SURE YOU PATCH SQL + ADD BOTH SCHEMAS WITH THE insert_hed_schema.php TOOL IN ACES/LORIS PRS FIRST

@christinerogers
Copy link
Collaborator

christinerogers commented Feb 1, 2024

let's change pr title to [EEG-BIDS/python]...

@cmadjar
Copy link
Collaborator

cmadjar commented Feb 16, 2024

@jeffersoncasimir who would best the best person to review this PR?

@jeffersoncasimir
Copy link
Contributor Author

jeffersoncasimir commented Feb 29, 2024

I think @regisoc or @laemtl would be since they have both reviewed one of the Loris counterparts

@christinerogers christinerogers changed the title [python] Events replace Annotations + HED Support [python] EEG-BIDS Events replace Annotations; plus adding HED Support Feb 29, 2024
@cmadjar cmadjar merged commit bc03c07 into aces:main Mar 27, 2024
1 check passed
@cmadjar cmadjar added this to the 26.0.0 milestone Apr 5, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants