Skip to content

Commit

Permalink
Fix order of SQL in release upgrade patch (#6728)
Browse files Browse the repository at this point in the history
The modules table must be created before the battery_manager
attempts to insert into the module.
  • Loading branch information
driusan committed Jun 15, 2020
1 parent 7655efe commit 38441d1
Showing 1 changed file with 30 additions and 30 deletions.
60 changes: 30 additions & 30 deletions SQL/Release_patches/22.0_To_23.0_upgrade.sql
Original file line number Diff line number Diff line change
Expand Up @@ -41,36 +41,6 @@ INSERT INTO user_perm_rel
(SELECT permID FROM permissions WHERE code='electrophysiology_browser_view_site')
);

SELECT 'Running: SQL/New_patches/2018-07-23-battery_manager_permissions.sql';

-- Add view permission for battery manager
INSERT INTO permissions (code, description, categoryID)
VALUES (
'battery_manager_view',
'View Battery Manager',
(SELECT ID FROM permissions_category WHERE Description = 'Permission')
);

-- Add edit permission for battery manager
INSERT INTO permissions (code, description, categoryID)
VALUES (
'battery_manager_edit',
'Add, activate, and deactivate entries in Test Battery',
(SELECT ID FROM permissions_category WHERE Description = 'Permission')
);

-- Give view permission to admin
INSERT INTO user_perm_rel (userID, permID)
SELECT ID, permID FROM users u JOIN permissions p
WHERE UserID='admin' AND code = 'battery_manager_view';

-- Give edit permission to admin
INSERT INTO user_perm_rel (userID, permID)
SELECT ID, permID FROM users u JOIN permissions p
WHERE UserID='admin' AND code = 'battery_manager_edit';

INSERT INTO modules (Name, Active) VALUES ('battery_manager', 'Y');

SELECT 'Running: SQL/New_patches/2019-02-08-multiple_mri_protocols.sql';

-- ####################################################################################
Expand Down Expand Up @@ -478,3 +448,33 @@ AND EXISTS (
AND pf.FileID = f.FileID
AND pf.Value = mvl.Value
);

SELECT 'Running: SQL/New_patches/2018-07-23-battery_manager_permissions.sql';

-- Add view permission for battery manager
INSERT INTO permissions (code, description, categoryID)
VALUES (
'battery_manager_view',
'View Battery Manager',
(SELECT ID FROM permissions_category WHERE Description = 'Permission')
);

-- Add edit permission for battery manager
INSERT INTO permissions (code, description, categoryID)
VALUES (
'battery_manager_edit',
'Add, activate, and deactivate entries in Test Battery',
(SELECT ID FROM permissions_category WHERE Description = 'Permission')
);

-- Give view permission to admin
INSERT INTO user_perm_rel (userID, permID)
SELECT ID, permID FROM users u JOIN permissions p
WHERE UserID='admin' AND code = 'battery_manager_view';

-- Give edit permission to admin
INSERT INTO user_perm_rel (userID, permID)
SELECT ID, permID FROM users u JOIN permissions p
WHERE UserID='admin' AND code = 'battery_manager_edit';

INSERT INTO modules (Name, Active) VALUES ('battery_manager', 'Y');

0 comments on commit 38441d1

Please # to comment.