Skip to content

Commit

Permalink
[issue_tracker] Resolves special characters in titles (#8842)
Browse files Browse the repository at this point in the history
Do not escape data being inserted in the issue tracker, it gets escaped on rendering.
  • Loading branch information
charlottesce committed Aug 16, 2023
1 parent 6705373 commit 3baac58
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions modules/issue_tracker/php/edit.class.inc
Original file line number Diff line number Diff line change
Expand Up @@ -447,11 +447,11 @@ class Edit extends \NDB_Page implements ETagCalculator
$historyValues = $this->getChangedValues($issueValues, $issueID, $user);

if (!empty($issueID)) {
$db->update('issues', $issueValues, ['issueID' => $issueID]);
$db->unsafeUpdate('issues', $issueValues, ['issueID' => $issueID]);
} else {
$issueValues['reporter'] = $user->getUsername();
$issueValues['dateCreated'] = date('Y-m-d H:i:s');
$db->insert('issues', $issueValues);
$db->unsafeInsert('issues', $issueValues);
$issueID = intval($db->getLastInsertId());
}

Expand Down Expand Up @@ -815,7 +815,7 @@ class Edit extends \NDB_Page implements ETagCalculator
'issueID' => $issueID,
'addedBy' => $user->getUsername(),
];
$db->insert('issues_history', $changedValues);
$db->unsafeInsert('issues_history', $changedValues);
}
}
}
Expand All @@ -838,7 +838,7 @@ class Edit extends \NDB_Page implements ETagCalculator
'addedBy' => $user->getUsername(),
'issueID' => $issueID,
];
$db->insert('issues_comments', $commentValues);
$db->unsafeInsert('issues_comments', $commentValues);
}
}

Expand Down

0 comments on commit 3baac58

Please # to comment.