[Performance] Do not load module logger from constructor

This is an attempt to solve the speed issues with demo-24.loris.ca.

In LORIS 23, there was no LORISInstance object that was used for
getting active modules, nor was there a logger instantiated from the
constructor. The added overhead of retrieving the log settings for
every module instantiation and LorisInstance->getActiveModules
instantiating every module is adding up to a lot of overhead in
the critical path on demo-24.loris.ca.

This moves the logger instantiation to be done after the
Module::factory call in the router instead of in the constructor.
The result is that it's only done once, instead of done n times
(where n is the number of modules.)

This doesn't get demo-24.loris.ca up to the speed of demo.loris.ca,
but it's significantly closer.

It's not clear why this performance regression is only happening on
demo and not in other environments.

php/libraries/Module.class.inc

@@ -169,10 +169,6 @@ abstract class Module extends \LORIS\Router\PrefixRouter
      */
     public function __construct(string $name, string $moduledir)
     {
-        $config   = \NDB_Factory::singleton()->config();
-        $loglevel = $config->getLogSettings()->getRequestLogLevel();
-
-        $this->logger = new \LORIS\Log\ErrorLogLogger($loglevel);
         parent::__construct(
             new \ArrayIterator(
                 [

src/Router/BaseRouter.php

@@ -94,15 +94,12 @@ public function handle(ServerRequestInterface $request) : ResponseInterface
 
         $factory           = \NDB_Factory::singleton();
         $ehandler          = new \LORIS\Middleware\ExceptionHandlingMiddleware();
-        $exceptionloglevel = $this->lorisinstance->getConfiguration()
-            ->getLogSettings()
-            ->getExceptionLogLevel();
+        $logSettings       = $this->lorisinstance->getConfiguration()->getLogSettings();
+        $exceptionloglevel = $logSettings->getExceptionLogLevel();
 
         if ($exceptionloglevel != "none") {
             $ehandler->setLogger(
-                new \LORIS\Log\ErrorLogLogger(
-                    $factory->config()->getLogSettings()->getExceptionLogLevel()
-                )
+                new \LORIS\Log\ErrorLogLogger($exceptionloglevel)
             );
         } else {
             $ehandler->setLogger(new \PSR\Log\NullLogger);
@@ -120,7 +117,17 @@ public function handle(ServerRequestInterface $request) : ResponseInterface
 
             $factory->setBaseURL($baseurl);
 
-            $module  = \Module::factory($modulename);
+            $module = \Module::factory($modulename);
+
+            $requestloglevel = $logSettings->getRequestLogLevel();
+            if ($requestloglevel != "none") {
+                $module->setLogger(
+                    new \LORIS\Log\ErrorLogLogger($requestloglevel)
+                );
+            } else {
+                $module->setLogger(new \PSR\Log\NullLogger);
+            }
+
             $mr      = new ModuleRouter($module);
             $request = $request->withURI($suburi);
             return $ehandler->process($request, $mr);