[dicom archive] Fix dicom archive details links (#9081)

Replace the obsolete link patches for the dicom-archive/view-details page with proper links. Resolves #9080
aces · Mar 11, 2024 · cde99c2 · cde99c2
1 parent 43c3c33
commit cde99c2
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 78 deletions.
diff --git a/modules/dicom_archive/js/view_details_link.js b/modules/dicom_archive/js/view_details_link.js
diff --git a/modules/dicom_archive/php/viewdetails.class.inc b/modules/dicom_archive/php/viewdetails.class.inc
@@ -357,24 +357,6 @@ class ViewDetails extends \NDB_Form
         );
     }
 
-    /**
-     * Overrides base getJSDependencies() to add additional JS files
-     *
-     * @return array of extra JS files that this page depends on
-     */
-    function getJSDependencies()
-    {
-        $factory = \NDB_Factory::singleton();
-        $baseURL = $factory->settings()->getBaseURL();
-        $deps    = parent::getJSDependencies();
-        return array_merge(
-            $deps,
-            [
-                $baseURL . "/dicom_archive/js/view_details_link.js",
-            ]
-        );
-    }
-
     /**
      * Generate a breadcrumb trail for this page.
      *
@@ -392,4 +374,3 @@ class ViewDetails extends \NDB_Form
         );
     }
 }
-
diff --git a/modules/dicom_archive/templates/form_viewDetails.tpl b/modules/dicom_archive/templates/form_viewDetails.tpl
@@ -3,9 +3,8 @@
   <tr>
     <th>Acquisition ID</th>
     <td>
-      <a class="dicom_archive" style="cursor: pointer"
-         data-patientname="{$archive.PatientName}">
-         {$archive.DicomArchiveID}
+      <a href="/mri_violations?patientName={$archive.PatientName}">
+        {$archive.DicomArchiveID}
       </a>
     </td>
   </tr>
@@ -124,9 +123,7 @@
             <td>{$archive_series[record].PhaseEncoding}</td>
             <td>{$archive_series[record].NumberOfFiles}</td>
             <td>
-              <a href="#" class="dicom_archive"
-                 data-patientname="{$archive.PatientName}"
-                 data-seriesuid="{$archive_series[record].SeriesUID}">
+              <a href="/mri_violations?patientName={$archive.PatientName}&seriesUID={$archive_series[record].SeriesUID}">
                 {$archive_series[record].SeriesUID}
               </a>
             </td>