[media] fixes issue when media module try to instantiate a non existi…

…ng instrument. (#8903) A try catch block was added to prevent the module to break if for any reason one of the instruments could not be instantiated. Resolves #8902
aces · Dec 5, 2023 · d7a599b · d7a599b
1 parent 47637c8
commit d7a599b
Showing 1 changed file with 13 additions and 4 deletions.
diff --git a/modules/media/php/mediafileprovisioner.class.inc b/modules/media/php/mediafileprovisioner.class.inc
@@ -91,10 +91,19 @@ class MediaFileProvisioner extends \LORIS\Data\Provisioners\DBRowProvisioner
 
         // make sure not to call the factory when $testname is null or ''
         if (!empty($testname) && !isset($this->_instrumentnames[$testname])) {
-            $this->_instrumentnames[$testname] = \NDB_BVL_Instrument::factory(
-                $this->lorisinstance,
-                $testname,
-            )->getFullname();
+            try {
+                $this->_instrumentnames[$testname] = \NDB_BVL_Instrument::factory(
+                    $this->lorisinstance,
+                    $testname,
+                )->getFullname();
+            } catch (\Exception $e) {
+                error_log(
+                    "There was a problem instantiating the instrument ".
+                    "'$testname'. Make sure the instrument is valid and ".
+                    "functional in order for it to be displayed in the media ".
+                    "module."
+                );
+            }
         }
         $row['fullName'] = $this->_instrumentnames[$testname] ?? null;