Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[New Profile] refreshing the page can cause multiple candidates to be created #5142

Closed
SantiagoTG opened this issue Aug 26, 2019 · 2 comments
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) Stale PR has had no activity. Should be triaged for review or possibly closed as low priority.

Comments

@SantiagoTG
Copy link
Contributor

When PSCID is set to sequential or random:
Steps:

  1. Go to new profile
  2. Fill in details
  3. Hit 'Create'
  4. On confirmation page, refresh, and press continue if prompted

At this point 2 candidates have been made with the same DoB and other details, but with different IDs
If possible we shouldn't allow form resubmission, theres also no way this is useful because all of the candidates won't have the same DoB.

It is possible this behaviour also exists on other forms throughout LORIS

Update by Dave McFarlane - To fix this we may need to add a CSRF token middleware, which probably isn't going to happen for this release [20.0].

https://redmine.cbrain.mcgill.ca/issues/14725

@SantiagoTG SantiagoTG added the Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) label Aug 28, 2019
@stale
Copy link

stale bot commented Jan 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale PR has had no activity. Should be triaged for review or possibly closed as low priority. label Jan 7, 2020
@driusan
Copy link
Collaborator

driusan commented Oct 29, 2021

This was fixed by #5808

@driusan driusan closed this as completed Oct 29, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) Stale PR has had no activity. Should be triaged for review or possibly closed as low priority.
Projects
None yet
Development

No branches or pull requests

2 participants