[new_profile] Pressing create multiple time creates multiple candidates "silently" #5808
Conversation
maltheism
added
Bug
|
Hi @zaliqarosli, I made the changes to make the code better as suggested by passing disable through props. |
|
@maltheism can you send this to 21.0-release? It's affecting some production instances and needs to go into a bugfix release before 22.0 |
maltheism
force-pushed
the
new_profile_fix_22.0
branch
from
20021a6
to
7f3ec86
Compare
|
@driusan PR rebased to 21.0-release |
|
@zaliqarosli re-review? |
| @@ -89,6 +90,9 @@ class NewProfileIndex extends React.Component { | |||
| } | |||
| formObject.append('fire_away', 'New Candidate'); | |||
|
|
|||
| // disable form from resubmission. | |||
| this.setState({disable: true}); | |||
There was a problem hiding this comment.
I would call this something a bit more descriptive like disableSubmit or something to that effect. Perhaps submitDisabled because it is written as more of a state (true/false) whereas disable sounds like an action (i.e. function).
There was a problem hiding this comment.
Also, I think if the submission fails, the button should be re-enabled so that the user can attempt another submission.
There was a problem hiding this comment.
Thanks @HenriRabalais, I added the suggested changes.
| @@ -103,6 +107,8 @@ class NewProfileIndex extends React.Component { | |||
| }); | |||
| } else { | |||
| resp.json().then((message) => { | |||
| // enable form from resubmission. | |||
There was a problem hiding this comment.
might as well fix the typo here while i test it manually!
There was a problem hiding this comment.
@HenriRabalais I fixed it. thanks!
|
@HenriRabalais @zaliqarosli @driusan everything was updated for suggestions & modifications. |
HenriRabalais
added
the
Passed Manual Tests
Brief summary of changes
Solves the bug where multiple candidates were made from the frontend form submission.
Note this implementation is similar to how it was done before. Another way would be to create a disabled props for the button component.
Testing instructions (if applicable)
Links to related tickets (GitHub, Redmine, ...)