Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[EEG Browser] Events and Electrode Panels Not Showing #7810

Closed
jesscall opened this issue Nov 9, 2021 · 0 comments · Fixed by #7811
Closed

[EEG Browser] Events and Electrode Panels Not Showing #7810

jesscall opened this issue Nov 9, 2021 · 0 comments · Fixed by #7811
Labels
24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)

Comments

@jesscall
Copy link
Contributor

jesscall commented Nov 9, 2021

Describe the bug
A previously merged PR (#7387) added features for Event and Electrode panels to populate with information from EEG BIDS files. Currently these features are not viewable because the links to events and electrode files are always null.

I believe this to be a result of this change in the code (see diff)

$downloadLinks = [];
if ($nSplit === 0) {
$downloadLinks[] = [
'groupName' => '',
'links' => $this->getPhysioFileDownloadlinks($physioFile),
];

Retrieval of the links data is not checking the proper array, there should be another level of abstraction:

epochsURL:
dbEntry
&& dbEntry.file.downloads[3]?.file
&& loris.BaseURL
+ '/electrophysiology_browser/file_reader/?file='
+ dbEntry.file.downloads[3].file,
electrodesURL:
dbEntry
&& dbEntry.file.downloads[1]?.file
&& loris.BaseURL
+ '/electrophysiology_browser/file_reader/?file='
+ dbEntry.file.downloads[1].file,
}));

To Reproduce
Steps to reproduce the behavior (attach screenshots if applicable):

  1. Go to EEG Browser
  2. Click on '....'
  3. Notice that you do not see Events or Electrode Panels (should look like screenshot in [EEG Browser] Signal Visualization, Events, Electrode map and EEG split files support #7387)

Screen Shot 2021-11-09 at 10 02 51 AM

What did you expect to happen?
To see the panels.

Server Environment (if known):
Note: We only support the most recent release of LORIS.

  • LORIS Version: main (24)
  • Linux distribution and Version: Ubuntu 18.04
  • MySQL/MariaDB Version: MySQL 5.7
@jesscall jesscall added Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) 24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 labels Nov 9, 2021
driusan pushed a commit that referenced this issue Nov 15, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant