Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[tools] Wrong path in recreate_conflicts.php #8063

Closed
CamilleBeau opened this issue Mar 18, 2022 · 1 comment
Closed

[tools] Wrong path in recreate_conflicts.php #8063

CamilleBeau opened this issue Mar 18, 2022 · 1 comment
Assignees
Labels
24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)

Comments

@CamilleBeau
Copy link
Contributor

CamilleBeau commented Mar 18, 2022

Describe the bug
Script failing because a slash is missing in the generic includes path
PHP Warning: require_once(/var/www/loris/toolsgeneric_includes.php): failed to open stream: No such file or directory in /var/www/loris/tools/recreate_conflicts.php on line 15
PHP Fatal error: require_once(): Failed opening required '/var/www/loris/toolsgeneric_includes.php' (include_path='.:/usr/share/php') in /var/www/loris/tools/recreate_conflicts.php on line 15

To Reproduce
Steps to reproduce the behavior (attach screenshots if applicable):

  1. Run script as intended
  2. See error
@CamilleBeau CamilleBeau added Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) 24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 labels Mar 18, 2022
driusan added a commit to driusan/Loris that referenced this issue Dec 20, 2022
This fixes the wrong path in the require_once for recreate_conflict.
It also passes a missing LorisInstance object to the ConflictDetector
function.

I still wasn't able to run the script to completion because I don't
have instruments that are properly configured on my sandbox for this
version of LORIS, but this resolves aces#8063.

Someone with up to date instruments should test the rest of the script.
driusan added a commit that referenced this issue Jan 12, 2023
This fixes the wrong path in the require_once for recreate_conflict.
It also passes a missing LorisInstance object to the ConflictDetector
function.

Resolves #8063.
@driusan
Copy link
Collaborator

driusan commented Jan 24, 2023

Path fixed by #8292

@driusan driusan closed this as completed Jan 24, 2023
zaliqarosli pushed a commit to zaliqarosli/Loris that referenced this issue Mar 6, 2023
This fixes the wrong path in the require_once for recreate_conflict.
It also passes a missing LorisInstance object to the ConflictDetector
function.

Resolves aces#8063.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
Projects
None yet
Development

No branches or pull requests

2 participants