Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[publication] Relative URL in notification emails #9132

Closed
jeffersoncasimir opened this issue Mar 14, 2024 · 0 comments · Fixed by #9186
Closed

[publication] Relative URL in notification emails #9132

jeffersoncasimir opened this issue Mar 14, 2024 · 0 comments · Fixed by #9186
Assignees
@skarya22
Labels
26.0.0-bugs Issues that were raised during the release testing for 26.0.0 Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)

Comments

@jeffersoncasimir
Copy link
Contributor

jeffersoncasimir commented Mar 14, 2024 •
edited
Loading

The notification e-mails send the user a relative URL instead of a complete and usable one:

Here is an example of a message (same applied for Edit notification):

Hello,

This is to confirm the project proposal "EEGNet" received on 2024-03-14.
We will notify you once this proposal has been reviewed. In the mean time, you
can view the project proposal through the following link: /publication/view_project/?id=4.

Thank you,
The demo Team

I think should include the full URL.
@jeffersoncasimir jeffersoncasimir added Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) 26.0.0-bugs Issues that were raised during the release testing for 26.0.0 labels Mar 14, 2024
@jeffersoncasimir jeffersoncasimir changed the title [publication] Relative URL in notification email [publication] Relative URL in notification emails Mar 14, 2024
@CamilleBeau CamilleBeau assigned skarya22 and unassigned CamilleBeau Mar 28, 2024
@skarya22 skarya22 mentioned this issue Mar 28, 2024
Merged
driusan pushed a commit that referenced this issue Apr 16, 2024
@skarya22
[Publication] Fix baseurl missing from emails (#9186)
3d53b05 
-The loris baseURL is now sent from the react pages to the ajax scripts on submit for both editing and uploading a new publication, and then is sent in the email.
- I did it this way as \NDB_Factory::singleton()->settings()->getBaseURL() does not work in ajax files, and since it is deprecated it made more sense to do a hotfix rather than investigating the issue with ajax.
- This was noticed and fixed for files in php folders in  PR#7807, however that same fix does not work for ajax. Thankfully publication is the only module with ajax still that uses getBaseUrl().

Resolves #9132
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@skarya22 skarya22

Labels
26.0.0-bugs Issues that were raised during the release testing for 26.0.0 Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Publication] Fix baseurl missing from emails skarya22/Loris
3 participants
@jeffersoncasimir @skarya22 @CamilleBeau