Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[media] Permission names need revising #9162

Closed
jeffersoncasimir opened this issue Mar 25, 2024 · 3 comments · Fixed by #9222
Closed

[media] Permission names need revising #9162

jeffersoncasimir opened this issue Mar 25, 2024 · 3 comments · Fixed by #9222
Assignees
@ridz1208 @racostas
Labels
26.0.0-bugs Issues that were raised during the release testing for 26.0.0 Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)

Comments

@jeffersoncasimir
Copy link
Contributor

jeffersoncasimir commented Mar 25, 2024 •
edited
Loading

The media module permissions are the following:

  • Media: Edit/Upload/Delete Candidate Media Files
  • Media: View/Download Candidate Media Files

Users with Media: View/Download Candidate Media Files are able to view files but do not have the option to download them; even their own uploads.

Only users with the Media: Edit/Upload/Delete Candidate Media Files can download.
However, I do not see a Delete feature on the v26 VM. There is a Hide File feature which can be listed instead.

The current names are not accurately reflecting the permission scopes.
@jeffersoncasimir jeffersoncasimir added Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) 26.0.0-bugs Issues that were raised during the release testing for 26.0.0 labels Mar 25, 2024
@ridz1208 ridz1208 self-assigned this Mar 26, 2024
@racostas racostas self-assigned this Apr 25, 2024
@racostas
Copy link
Contributor

Some comments:

  1. The issue of the user been able to see the "file name" and not to download it seems to be solved in 25 by PR.
    changed permision check to media_read to enable media downloads #8671
    Let's try to merge it in the 26 code-base.

  2. I don't seen we can really "Delete" file. So the name of this permission needs to change to Edit/Upload/HIde.

@racostas
Copy link
Contributor

Wil take care !

@driusan
Copy link
Collaborator

driusan commented Apr 25, 2024

I tried to merge 25 into 26 and the diff did not include that PR.

It's possible that it was eatten by a previously badly resolved merge. can you just re-send the change to main?

@racostas racostas mentioned this issue Apr 25, 2024
Merged
1 task
@christinerogers christinerogers mentioned this issue May 17, 2024
Closed
4 tasks
driusan pushed a commit that referenced this issue Jun 4, 2024
@racostas
[media] fixes permissions. Allows media_read to download, renames "De…
b4ce50a 
…lete" to "Hide". (#9222)

Allows the media_read permission to actually download (see) the files. The permission in this descriptions stats Media: View/Download Candidate Media Files but was not actually allowing to download (see) the documents.

media_write was substituted by media_read in the corresponding cases.

The permission Media: Edit/Upload/Delete Candidate Media Files is renamed to Media: Edit/Upload/Hide Candidate Media Files since we are not able to Delete files but to Hide they.

Fixes #9162
maximemulder pushed a commit to maximemulder/Loris that referenced this issue Sep 25, 2024
@racostas @maximemulder
[media] fixes permissions. Allows media_read to download, renames "De…
5be7d76 
…lete" to "Hide". (aces#9222)

Allows the media_read permission to actually download (see) the files. The permission in this descriptions stats Media: View/Download Candidate Media Files but was not actually allowing to download (see) the documents.

media_write was substituted by media_read in the corresponding cases.

The permission Media: Edit/Upload/Delete Candidate Media Files is renamed to Media: Edit/Upload/Hide Candidate Media Files since we are not able to Delete files but to Hide they.

Fixes aces#9162
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@ridz1208 ridz1208

@racostas racostas

Labels
26.0.0-bugs Issues that were raised during the release testing for 26.0.0 Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[media] fixes permissions. Allows media_read to download, renames "Delete" to "Hide". racostas/Loris
4 participants
@driusan @ridz1208 @jeffersoncasimir @racostas