Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[notification] Notification email sender name incorrect #9202

Closed
maximemulder opened this issue Apr 11, 2024 · 0 comments · Fixed by #9203
Closed

[notification] Notification email sender name incorrect #9202

maximemulder opened this issue Apr 11, 2024 · 0 comments · Fixed by #9203
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)

Comments

@maximemulder
Copy link
Contributor

maximemulder commented Apr 11, 2024 •
edited
Loading

Describe the bug

While testing #9193, I noticed that although the PR is fine, the name of the notifier appearing in the email is wrong, it displays the user ID instead.

i.e., on my VM, instead of displaying The user Maxime Mulder <maxime.mulder@mcin.ca> has done ... in the email, it displays The user 2 <maxime.mulder@mcin.ca> has done ....

To Reproduce

  1. Trigger an email notification in which the user name appears (such as a media file upload).
@maximemulder maximemulder added the Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) label Apr 11, 2024
@maximemulder maximemulder mentioned this issue Apr 11, 2024
Merged
driusan pushed a commit that referenced this issue Apr 16, 2024
@maximemulder
[notification] Fix sender name in email (#9203)
e96d5a8 
Display the name of the user instead of their ID in the notification emails.

Fixes #9202
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[notification] Fix sender name in email maximemulder/Loris
1 participant
@maximemulder