Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Deprecated LORIS function call in recreate_conflicts.php script #9267

Closed
racostas opened this issue May 15, 2024 · 0 comments · Fixed by #9280
Closed

Deprecated LORIS function call in recreate_conflicts.php script #9267

racostas opened this issue May 15, 2024 · 0 comments · Fixed by #9280
Assignees
@racostas @ay-bh
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) GSOC Google Summer of Code related

Comments

@racostas
Copy link
Contributor

Describe the bug
The function getAllInstruments() used by recreate_conflicts.php it been deprecated in LORIS 24. We should changed it by getInstrumentsNamesList() as described in the following error message.

image

To Reproduce
Steps to reproduce the behavior (attach screenshots if applicable):

  1. In /var/www/loris/tools, run php recreate_conflicts.php all
  2. The deprecation error message will be shown before the script starts recreating the conflicts.

What did you expect to happen?
The script to use the new and more accurate function when retrieving all the instruments.
@racostas racostas added Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) GSOC Google Summer of Code related labels May 15, 2024
@racostas racostas self-assigned this May 15, 2024
@ay-bh ay-bh mentioned this issue May 25, 2024
Merged
driusan pushed a commit that referenced this issue Jun 3, 2024
@ay-bh
Refactor recreate_conflicts.php to use getInstrumentNamesList() (#9280)
a54468d 
Refactored recreate_conflicts.php to replace the deprecated Utility::getAllInstruments() function with NDB_BVL_Instrument::getInstrumentNamesList($lorisInstance) 

Resolves #9267
maximemulder pushed a commit to maximemulder/Loris that referenced this issue Sep 25, 2024
@ay-bh @maximemulder
Refactor recreate_conflicts.php to use getInstrumentNamesList() (aces…
c3e5524 
…#9280)

Refactored recreate_conflicts.php to replace the deprecated Utility::getAllInstruments() function with NDB_BVL_Instrument::getInstrumentNamesList($lorisInstance) 

Resolves aces#9267
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@racostas racostas

@ay-bh ay-bh

Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) GSOC Google Summer of Code related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[tools] Refactor recreate_conflicts.php to use getInstrumentNamesList() ay-bh/Loris
2 participants
@racostas @ay-bh