-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Untitled #1
Closed
Closed
Untitled #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driusan
added
the
Cleanup
PR or issue introducing/requiring at least one clean-up operation
label
Dec 16, 2014
samirdas
pushed a commit
that referenced
this pull request
Sep 25, 2015
make utility function use factory for DB and fix unittest
stellarxo
referenced
this pull request
in stellarxo/Loris
May 9, 2016
Code for Enrollment Statistics Report
AnyhowStep
added a commit
to AnyhowStep/Loris
that referenced
this pull request
May 24, 2017
ZainVirani
referenced
this pull request
in ZainVirani/Loris
Jun 2, 2017
Fixed user project multi-select display
llevitis
pushed a commit
to llevitis/Loris
that referenced
this pull request
Jul 10, 2017
[modules] added module name to the 'Clinical' menu (source 0000-00-02-Menus.sql)
This was referenced Oct 4, 2021
driusan
pushed a commit
that referenced
this pull request
Oct 14, 2021
Fix error ``` PHP Fatal error: Uncaught TypeError: NDB_BVL_Instrument::factory(): Argument #1 ($loris) must be of type LORIS\LORISInstance, string given, called in /var/www/Loris/tools/CouchDB_Import_Instruments.php on line 196 and defined in /var/www/Loris/php/libraries/NDB_BVL_Instrument.class.inc:225 ``` In CouchDB_Import_Instruments.php Fixes #7680
driusan
added a commit
that referenced
this pull request
Oct 29, 2021
When accessing an instrument from RB, I got the error: ``` Fatal error: Uncaught TypeError: Argument 1 passed to ValidatableIdentifier::__construct() must be of the type string, null given, called in /home/driusan/Code/Loris/php/libraries/NDB_BVL_Instrument.class.inc on line 2863 and defined in /home/driusan/Code/Loris/php/libraries/Valida tableIdentifier.php:57 Stack trace: #0 /home/driusan/Code/Loris/php/libraries/NDB_BVL_Instrument.class.inc(2863): ValidatableIdentifier->__co nstruct(NULL) #1 /home/driusan/Code/Loris/src/Middleware/UserPageDecorationMiddleware.php(241): NDB_BVL_Instrument->handle(Object(Laminas\Dia ctoros\ServerRequest)) #2 /home/driusan/Code/Loris/src/Middleware/PageDecorationMiddleware.php(57): LORIS\Middleware\UserPageDecorationMiddle ware->process(Object(Laminas\Diactoros\ServerRequest), Object(NDB_BVL_Instrument_aosi)) #3 /home/driusan/Code/Loris/php/libraries/NDB_Page.cl ass.inc(735): LORIS\Middleware\PageDecorationMiddleware->process(Object(Laminas\Diactoros\ServerRequest), Object(NDB_BVL_Instrument_aosi)) #4 /home/driusan/Code/Loris/php/libraries/NDB_BVL_In in /home/driusan/Code/Loris/php/libraries/ValidatableIdentifier.php on line 57 ``` This fixes the type error so that the instrument page loads.
driusan
pushed a commit
that referenced
this pull request
Dec 1, 2022
This fixes the error: ``` <b>Fatal error</b>: Uncaught TypeError: ValidatableIdentifier::__construct(): Argument #1 ($value) must be of type string, int given, called in /var/www/loris/modules/behavioural_qc/php/models/incompletedto.class.inc on line 126 ``` when the module is run on PHP 8.1.
CamilleBeau
pushed a commit
to CamilleBeau/Loris
that referenced
this pull request
Dec 5, 2022
…tion update 2021 07 27 diagnosis evolution
driusan
added a commit
that referenced
this pull request
Nov 24, 2023
This fixes 2 problems with loading the publication module on Raisinbread: 1. When trying to load the page, I get the error: <b>Deprecated</b>: htmlspecialchars_decode(): Passing null to parameter #1 ($string) of type string is deprecated in <b>/home/driusan/Code/Loris/modules/publication/php/publication.class.inc</b> on line <b>304</b><br /> with PHP 8.2. 2. The Form.js imports were missing.
driusan
added a commit
that referenced
this pull request
Dec 12, 2023
Fix the warnings: ``` <b>Deprecated</b>: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in <b>modules/instrument_list/php/instrument_list_controlpanel.class.inc</b> on line <b>475</b><br /> <br /> <b>Deprecated</b>: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in <b>modules/instrument_list/php/instrument_list_controlpanel.class.inc</b> on line <b>514</b><br /> ``` in PHP 8.2 and above.
1 task
driusan
pushed a commit
that referenced
this pull request
Apr 4, 2024
Fixes error on statistics page: ``` [CRITICAL] /var/www/Loris/php/libraries/User.class.inc:476: Uncaught TypeError: User::hasProject(): Argument #1 ($projectID) must be of type ProjectID, string given, called in /var/www/Loris/modules/statistics/php/statistics_site.class.inc on line 134 and defined in /var/www/Loris/php/libraries/User.class.inc:476 ``` Fixes #9137
driusan
pushed a commit
that referenced
this pull request
Aug 27, 2024
…www/loris/tools/generic_includes.php on line 28" - 26 branch (#9317) This fixes the script generic_includes.php that calls the $DB variable before it is defined when calling LorisInstance. Without this fix, anything calling generic_includes.php will trigger the following error: ``` Undefined variable in /var/www/loris/tools/generic_includes.php on line 28 PHP Fatal error: Uncaught TypeError: LORIS\\LorisInstance::__construct(): Argument #1 ($db) must be of type Database, null given, called in /var/www/loris/tools/generic_includes.php on line 27 ```
driusan
pushed a commit
that referenced
this pull request
Oct 1, 2024
…www/loris/tools/generic_includes.php on line 28" - 25 branch (#9318) This fixes the script `generic_includes.php` that calls the $DB variable before it is defined when calling LorisInstance. Without this fix, anything calling `generic_includes.php` will trigger the following error: ``` Undefined variable in /var/www/loris/tools/generic_includes.php on line 28 PHP Fatal error: Uncaught TypeError: LORIS\\LorisInstance::__construct(): Argument #1 ($db) must be of type Database, null given, called in /var/www/loris/tools/generic_includes.php on line 27 ```
This was referenced Nov 14, 2024
Closed
This pull request was closed.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an extra helper function to utility class which I think is useful for other projects.