Fixed bug where search keyword crashes other menus #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The base NDB_Menu_Filter class maintains the filters as you go between pages. This means that if you set a search key, and then go to a page which doesn't have any searchKeywords fields defined, the SQL generated becomes invalid. This updates the code so that the filter checks if $this->searchKeyword is set and non-empty (the field defined by the form) instead of $this->searchKey['keyword'] (the field with the user input)
driusan
added
the
Bug
samirdas
added a commit
that referenced
this pull request
Dec 15, 2015
Fixed bug where search keyword crashes other menus
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base NDB_Menu_Filter class maintains the filters
as you go between pages. This means that if you set
a search key, and then go to a page which doesn't have
any searchKeywords fields defined, the SQL generated
becomes invalid.
This updates the code so that the filter checks if
$this->searchKeyword is set and non-empty (the field
defined by the form) instead of $this->searchKey['keyword'](the field with the user input)