Data Release Module #1602
Merged
Data Release Module #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jkat
added
Feature
|
@nicolasbrossard Check ca - ben don cool. |
Current coverage is
|
| } | ||
| header("Location: ../main.php?test_name=data_release&uploadSuccess=true"); | ||
| } else { | ||
| echo "There was an error uploading the file"; |
There was a problem hiding this comment.
This should include a 400 Bad Request header too.
| ); | ||
| $uid = $db->pselectOne( | ||
| "SELECT ID FROM users WHERE " | ||
| . "UserID='{$user->getUsername()}'", |
There was a problem hiding this comment.
This should be a prepared statement.
Jkat
force-pushed
the
Data_Release_Module
branch
from
c2c3117
to
08ccc45
Compare
|
Please make note that deleting access or releases is not implemented. |
| 'data_release_id' => $data_release_id, | ||
| ) | ||
| ); | ||
| header("Location: /data_release/?addpermissionSuccess=true"); |
There was a problem hiding this comment.
This is missing the baseURL so won't work on things not installed directly on the host @Jkat
driusan
added
Needs Work
Jkat
removed
the
Needs Work
|
Thanks @driusan, fixed. |
FILE: ...vis/build/aces/Loris/modules/data_release/ajax/AddPermission.phpFOUND 1 ERROR AFFECTING 1 LINE27 | ERROR | [x] Whitespace found at end of linePHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY |
| . " data_release_permissions drp" | ||
| . " ON (dr.id=drp.data_release_id)" | ||
| . " JOIN users u ON (u.ID=drp.userid)" | ||
| . " WHERE u.UserID='{$user->getUsername()}'"; |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can package your releases and distribute them here.