Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

allow post data to be resent instead of discarded after redirect #2941

Merged
merged 1 commit into from
Oct 5, 2017
Merged

allow post data to be resent instead of discarded after redirect #2941

merged 1 commit into from
Oct 5, 2017

Conversation

xlecours
Copy link
Contributor

This pull request should allow post data to be automatically resent after a redirect. It chnage the HTTP status code from 301 to 307.

See also: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/307

@xlecours xlecours added the Feature PR or issue introducing/requiring at least one new feature label Jul 11, 2017
@xlecours xlecours added this to the 17.2 milestone Jul 11, 2017
@driusan driusan removed this from the 18.1 milestone Oct 2, 2017
@kongtiaowang kongtiaowang added the Passed Manual Tests PR has undergone proper testing by at least one peer label Oct 5, 2017
@kongtiaowang kongtiaowang self-requested a review October 5, 2017 17:08
kongtiaowang
kongtiaowang approved these changes Oct 5, 2017
View reviewed changes
Copy link
Contributor

@kongtiaowang kongtiaowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kongtiaowang kongtiaowang added this to the 18.0.1 milestone Oct 5, 2017
@driusan driusan changed the base branch from 17.1-dev to bugfix October 5, 2017 17:56
@driusan driusan merged commit 198a259 into aces:bugfix Oct 5, 2017
@driusan driusan modified the milestone: 18.0.1 Oct 5, 2017
@Jkat
Copy link
Contributor

Jkat commented Oct 13, 2017

@xlecours were there specific cases/examples in LORIS where this caused problems?

@xlecours xlecours deleted the module_name_redirect_code branch August 4, 2021 13:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kongtiaowang kongtiaowang kongtiaowang approved these changes

Assignees
No one assigned
Labels
Feature PR or issue introducing/requiring at least one new feature Passed Manual Tests PR has undergone proper testing by at least one peer
Projects
None yet
Milestone
18.0.1
Development

Successfully merging this pull request may close these issues.
4 participants
@xlecours @Jkat @kongtiaowang @driusan