[JS] Remove all the compiled artifacts #3891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driusan
force-pushed
the
RemoveCompileArtifacts
branch
from
a0aecf9
to
c57e938
Compare
|
Hey @driusan if a developer wants to include a JS file that is not react but just some custom functions for utility. The js file will still go into the JS directory but we modify the .gitignore file? |
|
@intralizee You could either do that or just put it in the jsx folder and transpile it as a no-op since js is a subset of jsx. |
driusan
added
Cleanup
|
Added blocked because I don't want to risk conflicts with #3895 and I'd rather that one goes in first. |
driusan
added
the
Blocked
Now that there is a build step incorporated into installing LORIS to generate the VERSION file, there's no longer any need to directly track the compiled javascript files in git (which is a recipe for out of date files and conflicts.) This removes all of the compiled JSX artifacts in order to make life easier for developers.
driusan
force-pushed
the
RemoveCompileArtifacts
branch
from
c57e938
to
cc9d7ea
Compare
driusan
removed
the
Blocked
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that there is a build step incorporated into installing
LORIS to generate the VERSION file, there's no longer any need
to directly track the compiled javascript files in git (which
is a recipe for out of date files and conflicts.)
This removes all of the compiled JSX artifacts in order to
make life easier for developers.