[Imaging Uploader] Prevent duplicate insertions #4024
Conversation
johnsaigle
added
the
Bug
| (ISNULL(Inserting) OR Inserting=0), UploadID, NULL) as UploadID | ||
| FROM mri_upload WHERE UploadLocation LIKE :ul", | ||
| array('ul' => "%$file_name") | ||
| ); |
There was a problem hiding this comment.
It might be good to add a file_exists check here if you have access to the full path to the file. This only checks whether there's a record in the database.
| //////// Make sure there's no existing identical entry //////////////// | ||
| //////// for "new" scans ////////////////////////////////////////////// | ||
| /////////////////////////////////////////////////////////////////////// | ||
| $updateFile = $args['values']['overwrite'] ? true : false; |
There was a problem hiding this comment.
I'm not sure this ternary operator is necessary. What's the value of 'overwrite'? Can you just pass it along to L387?
There was a problem hiding this comment.
i just copied it over from the importFile($file, $args) function. i think it only gets set when the user confirms they want the original upload overwritten
kongtiaowang
added
the
Passed Manual Tests
|
pass test and ready to go. |
|
I opened two tabs in Google Chrome and tried uploading the same file in both of these tabs: one of them reported an upload failure, saying that the file was already uploaded (as expected) 👍 |
| /////////////////////////////////////////////////////////////////////// | ||
| //////// Make sure there's no existing identical entry //////////////// | ||
| //////// for "new" scans ////////////////////////////////////////////// | ||
| /////////////////////////////////////////////////////////////////////// |
There was a problem hiding this comment.
How long did it take you to type all those slashes?
Brief summary of changes
Imaging Uploader only checks if a file already exists on the front end. This makes it possible to insert duplicate scans which happens surprisingly often on CCNA. This change adds a backend check for an existing mri_upload entry that is not being intentionally overwritten / updated.
This resolves issue...
mri_upload duplicates
To test this change...
Open the Imaging Uploader Upload tab in two browser tabs. Fill out both simultaneously for the same scan, then submit one after the other. The first submission should go through and the other should throw an error.