Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Instruments] Revert intval of CommentID because CommentID is not an int #4246

Merged
merged 1 commit into from
Jan 10, 2019

Conversation

zaliqarosli
Copy link
Contributor

Brief summary of changes

CommentID is an alpha-numerical string. Removing the intval here allows me to correctly access an instrument's subtest pages.

To test this change...

  • On major, try to access an instrument's second page. The link is broken
  • On this branch, it's fixed

@zaliqarosli
Copy link
Contributor Author

@driusan I just realized that you fixed this here #4229. I will close this PR if you feel that your PR will be merged soon

@driusan
Copy link
Collaborator

driusan commented Jan 10, 2019

This is clearly wrong and needs to be fixed, I'll just merge it.

@driusan driusan merged commit 4b1193f into aces:major Jan 10, 2019
@ridz1208 ridz1208 added this to the 21.0.0 milestone Jan 19, 2019
@zaliqarosli zaliqarosli deleted the 2019-01-09-RemoveIntValOnCommentID branch December 9, 2022 21:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants