Brainbrowser not working after fixing paths in violation tables #4347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… after the update to the violation tables
cmadjar
added
Add to Release Notes
3 tasks
cmadjar
added
the
Critical to release
|
@ridz1208 As we discussed, I added the flag Critical to release so that this PR makes it to 20.3 along with the MRI one linked in the description. Thanks! |
PapillonMcGill
approved these changes
Mar 4, 2019
kchatpar
pushed a commit
to kchatpar/Loris
that referenced
this pull request
Apr 15, 2019
… tables (aces#4347) The paths stored in the 3 violation tables (MRICandidateErrors, mri_violations_log and mri_protocol_violated_scans) were wrong and a tool script has been provided on the LORIS-MRI side to correct the paths to the MINC files so that they are valid paths. Due to the bad paths being present in those tables, brainbrowser was hacked on the LORIS side to be able to display the images. Now that the paths are corrected, this hack can be removed which also simplifies the code.
cmadjar
deleted the
fix_mri_violations_with_updated_location_in_violation_tables
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
The paths stored in the 3 violation tables (
MRICandidateErrors,mri_violations_logandmri_protocol_violated_scans) were wrong and a tool script has been provided on the LORIS-MRI side to correct the paths to the MINC files so that they are valid paths.Due to the bad paths being present in those tables, brainbrowser was hacked on the LORIS side to be able to display the images. Now that the paths are corrected, this hack can be removed which also simplifies the code.
This PR goes with aces/Loris-MRI#403 on the LORIS-MRI side where more details can be found regarding the bad paths stored in the violation tables.
This resolves issue...
Caveat for existing projects
Make sure to run the tool script called
cleanup_paths_of_violation_tables.plon the LORIS-MRI side in order to update the MINC location in the violation tables.To test this change...