[SinglePointLogin] fix passwordAuthenticate accessing $_POST superglobal #4356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlecours
added
Bug
PapillonMcGill
approved these changes
Feb 25, 2019
kchatpar
pushed a commit
to kchatpar/Loris
that referenced
this pull request
Apr 15, 2019
…bal (aces#4356) This removes the $_POST['username'] in favor of $username variable passed to the function as a parameter. It fixes `PHP Fatal error: Uncaught TypeError: Argument 1 passed to SinglePointLogin::accountLocked() must be of the type string, null given` occurring because the API consumes 'application/json' content-type and $_POST is populated only; > [...] when using application/x-www-form-urlencoded or multipart/form-data as the HTTP Content-Type in the request. > http://php.net/manual/en/reserved.variables.post.php
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This remove the $_POST['username'] in favor of $username variable passed to the function as a parameter.
It fixes
PHP Fatal error: Uncaught TypeError: Argument 1 passed to SinglePointLogin::accountLocked() must be of the type string, null givenoccurring because the API consumes 'application/json' content-type and $_POST is populated only;