[Documentation] Fixed the link to codingstandards.md in Contributing.md #4370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @kchatpar it looks like this is based on the wrong branch. You'll need to rebase it on your local VM to make sure it's based on |
johnsaigle
added
Bug
kchatpar
changed the title
kchatpar
force-pushed
the
fixdocumentation
branch
from
7537a50
to
c61df17
Compare
kchatpar
removed
the
Needs Rebase
johnsaigle
previously approved these changes
Feb 28, 2019
driusan
reviewed
Feb 28, 2019
CONTRIBUTING.md
Outdated
| @@ -5,7 +5,7 @@ do before contributing is probably # for the [LORIS developers' | |||
| mailing list](http://www.bic.mni.mcgill.ca/mailman/listinfo/loris-dev). | |||
|
|
|||
| Your next step before issuing a pull request is to review our | |||
| [Coding Standards](./docs/CodingStandards). If you are doing | |||
| [Coding Standards](https://github.com/aces/Loris/blob/minor/docs/CodingStandards.md). If you are doing | |||
There was a problem hiding this comment.
This should not include a full URL, it's just missing the extension (and according to what someone said on a different PR, shouldn't have the ./, I think)
There was a problem hiding this comment.
Yeah I think this could just be docs/CodingStandards.md
There was a problem hiding this comment.
I just updated the code to the non-url style.
christinerogers
approved these changes
Mar 1, 2019
PapillonMcGill
approved these changes
Mar 4, 2019
kchatpar
pushed a commit
to kchatpar/Loris
that referenced
this pull request
Apr 15, 2019
…md (aces#4370) Fix broken link which was missing an extension.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the broken link to CodingStandards.md in CONTRIBUTING.MD.
This resolves issue Github #4361
To test this change...