Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fixed MRI uploader with auto-launch turned on that was not working. #4400

Merged
merged 1 commit into from
Mar 19, 2019
Merged

Fixed MRI uploader with auto-launch turned on that was not working. #4400

merged 1 commit into from
Mar 19, 2019

Conversation

nicolasbrossard
Copy link
Contributor

@nicolasbrossard nicolasbrossard commented Mar 18, 2019 •
edited by cmadjar
Loading

Brief summary of changes

As the tile says, when auto-launch was turned on, the MRI uploader always failed to automatically execute the MRI pipeline. This bug was introduced in 20.2. This fix should consequently be propagated to that branch also.

This resolves issue...

To test this change...

  • Make sure that auto-launch is set to true in the Config module and upload a valid scan.
  • Verify that the MRI pipeline is started automatically when the scan is successfully uploaded.

"Priority High", as instructed by @ridz1208

@nicolasbrossard nicolasbrossard added Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) Priority: High PR or issue should be prioritised over others for review and testing labels Mar 18, 2019
johnsaigle
johnsaigle approved these changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@johnsaigle johnsaigle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to fix an issue introduced by the combination of #3944 and #3906 (branch merging issue?)

@driusan driusan removed the Priority: High PR or issue should be prioritised over others for review and testing label Mar 18, 2019
@cmadjar cmadjar added the Priority: High PR or issue should be prioritised over others for review and testing label Mar 18, 2019
cmadjar
cmadjar approved these changes Mar 18, 2019
View reviewed changes
Copy link
Collaborator

@cmadjar cmadjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmadjar cmadjar added the Passed Manual Tests PR has undergone proper testing by at least one peer label Mar 18, 2019
@driusan driusan merged commit 623f382 into aces:bugfix Mar 19, 2019
@driusan driusan removed the Priority: High PR or issue should be prioritised over others for review and testing label Mar 19, 2019
@ridz1208 ridz1208 added this to the 20.2.1 milestone Mar 25, 2019
kchatpar pushed a commit to kchatpar/Loris that referenced this pull request Apr 15, 2019
@nicolasbrossard
Fixed MRI uploader with auto-launch turned on that was not working. (a…
1866b2b 
…ces#4400)

When auto-launch was turned on, the MRI uploader always failed to automatically execute the MRI pipeline.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cmadjar cmadjar cmadjar approved these changes

@johnsaigle johnsaigle johnsaigle approved these changes

Assignees
No one assigned
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) Passed Manual Tests PR has undergone proper testing by at least one peer
Projects
None yet
Milestone
20.2.1
Development

Successfully merging this pull request may close these issues.
5 participants
@nicolasbrossard @cmadjar @johnsaigle @driusan @ridz1208