[Issue_tracker] bug fix for 20.3-release | can't edit an issue #4454
Conversation
kongtiaowang
added
the
Bug
|
@ridz1208 |
| @@ -26,7 +26,7 @@ function formatColumn(column, cell, rowData, rowHeaders) { | |||
| if (column === 'Title') { | |||
| let cellLinks = []; | |||
| cellLinks.push( | |||
| <a href={loris.BaseURL + '/issue_tracker/issue/' + row['Issue ID']}> | |||
| <a href={loris.BaseURL + '/issue_tracker/issue/?issueID=' + row['Issue ID']}> | |||
There was a problem hiding this comment.
This is not correct. The ID should be coming from the handle method parsing the URL at https://github.com/aces/Loris/blob/minor/modules/issue_tracker/php/issue.class.inc#L144
There was a problem hiding this comment.
@driusan If use RESTful API in this case, the "QueryString.get()" will get a null value.
Major branch is also using "?issueID=" on URL. I think if you need this to be fixed, it should be on Major branch.
There was a problem hiding this comment.
in that case the major branch is wrong and also needs to be fixed. The ID should be coming from the URL, not the query string
There was a problem hiding this comment.
@driusan will look into the handle function and try to solve the issue
ridz1208
added
the
Critical to release
…4454) Fix bug where an issue could not be edited in issue tracker, they would create a new issue instead.
…4454) Fix bug where an issue could not be edited in issue tracker, they would create a new issue instead.
Brief summary of changes
Give an issueID on url.
This resolves issue...
https://redmine.cbrain.mcgill.ca/issues/16241
To test this change...
edit an issue