Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Training] Remove training module #4535

Merged
merged 2 commits into from
May 15, 2019
Merged

[Training] Remove training module #4535

merged 2 commits into from
May 15, 2019

Conversation

driusan
Copy link
Collaborator

@driusan driusan commented May 13, 2019

This removes the training module, which is currently only used by CCNA
project (which also overrides the module.)

@driusan driusan mentioned this pull request May 13, 2019
Closed
@driusan driusan requested a review from ridz1208 May 13, 2019 17:02
@driusan driusan mentioned this pull request May 13, 2019
Merged
@kongtiaowang
Copy link
Contributor

raisinbread/RB_files/RB_certification_training_quiz_answers.sql
raisinbread/RB_files/RB_certification_training_quiz_questions.sql
raisinbread/RB_files/RB_certification_training.sql

Dave MacFarlane added 2 commits May 13, 2019 15:07
[Training] Remove training module
d574c74 
This removes the training module, which is currently only used by CCNA
project (which also overrides the module.)
Remove raisinbread files
76819b0
@johnsaigle johnsaigle added Cleanup PR or issue introducing/requiring at least one clean-up operation SQL PR contains SQL modifications such as schema changes and new SQL scripts Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix and removed Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix labels May 13, 2019
@johnsaigle
Copy link
Contributor

Failing Travis due to some issue with Subprojects.

@driusan
Copy link
Collaborator Author

driusan commented May 14, 2019

Restarted 7.2 and it's passing now.

@johnsaigle johnsaigle added the Passed Manual Tests PR has undergone proper testing by at least one peer label May 14, 2019
johnsaigle
johnsaigle approved these changes May 14, 2019
View reviewed changes
Copy link
Contributor

@johnsaigle johnsaigle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R.I.P.

@ridz1208
Copy link
Collaborator

Yu gonplei ste odon

@ridz1208 ridz1208 merged commit 7aa146e into aces:21.0-release May 15, 2019
@ridz1208 ridz1208 added this to the 21.0.0 milestone May 16, 2019
@johnsaigle johnsaigle mentioned this pull request May 27, 2019
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@johnsaigle johnsaigle johnsaigle approved these changes

@ridz1208 ridz1208 Awaiting requested review from ridz1208

Assignees
No one assigned
Labels
Cleanup PR or issue introducing/requiring at least one clean-up operation Passed Manual Tests PR has undergone proper testing by at least one peer SQL PR contains SQL modifications such as schema changes and new SQL scripts
Projects
None yet
Milestone
21.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@driusan @kongtiaowang @johnsaigle @ridz1208