[brainbrowser] Add possibility to read nii.gz files with BB #5314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmadjar
added
the
Bug
johnsaigle
approved these changes
Oct 15, 2019
driusan
reviewed
Oct 25, 2019
| @@ -53,7 +53,7 @@ | |||
| header('Content-Type: application/x-mnc'); | |||
| } | |||
| header('X-FileID: ' . $_REQUEST['file_id']); | |||
| readfile($image_path); | |||
| readgzfile($image_path); | |||
There was a problem hiding this comment.
Isn't this going to break 1. minc and 2. non-gzipped .nii files?
There was a problem hiding this comment.
@driusan Should not. File that are not in gz format are read as is.
There was a problem hiding this comment.
@driusan as @PapillonMcGill mentioned, .mnc and .nii files can still be open with BB. I tested it before sending the PR :)
There was a problem hiding this comment.
readgzfile() can be used to read a file which is not in gzip format; in this case readgzfile() will directly read from the file without decompression.
|
@driusan Just in case I retested it to make sure |
driusan
approved these changes
Oct 28, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
nii.gzfiles could not be opened with the brainbrowser module. This PR modifies the way we read the image so that if the file is gzipped, it is decompressed first before reading the content of the file.